[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Dominik 'Rathann' Mierzejewski]

On Thursday, 05 June 2008 at 10:28, Diego Biurrun wrote:
> On Wed, Jun 04, 2008 at 09:29:19PM +0200, Michael Niedermayer wrote:
> > On Wed, Jun 04, 2008 at 05:34:13PM +0200, Luca Barbato wrote:
> > > Reimar Döffinger wrote:
> > > > On Sat, Apr 12, 2008 at 05:51:08PM +0200, uau wrote:
> > > >>
> > > >> Log:
> > > >> Reindent demuxer.c
> > > > 
> > > > This is not only a reindentation,
> > > 
> > > It is, at least if you consider reindent as "do what indent does"
> > 
> > ----------------------------------------
> > These remove comments, remove outcommented code, ...
> > this definitly is not what indent does and its just what i quickly spotted
> 
> We've been over this before.  The commit message was bad, it has been
> fixed.  You can hardly accuse Uoti of writing bad commit messages in
> general.
> 
> > And thats why such commits are so bad and why we all complain, they are a
> > nightmare to review, you missed the things above, others missed them too.
> 
> I posted a diff without whitespace changes to this thread.  It was not
> at all hard to review.  Move on, nothing to see here...

And that's what should've been committed.

> > Besides demuxer.c is not maintained by uoti ...
> 
> Other files were reindented without a big outcry before.

That doesn't make it right. He should've asked in the mailing list
first. Isn't it standard procedure? Post a patch, ask for objections
and threaten to commit in X days if there aren't any. It's not too
much to ask IMHO.

Besides, what happened to your promise to revert and fix all Uoti's
bad commits?

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | Livna http://rpm.livna.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan