[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Diego Biurrun]

On Thu, Jun 05, 2008 at 07:52:36PM +0200, Michael Niedermayer wrote:
> On Thu, Jun 05, 2008 at 10:28:34AM +0200, Diego Biurrun wrote:
> > On Wed, Jun 04, 2008 at 09:29:19PM +0200, Michael Niedermayer wrote:
> > > On Wed, Jun 04, 2008 at 05:34:13PM +0200, Luca Barbato wrote:
> > > > Reimar Döffinger wrote:
> > > > > On Sat, Apr 12, 2008 at 05:51:08PM +0200, uau wrote:
> > > > >>
> > > > >> Log:
> > > > >> Reindent demuxer.c
> > > > > 
> > > > > This is not only a reindentation,
> > > > 
> > > > It is, at least if you consider reindent as "do what indent does"
> > > 
> > > ----------------------------------------
> > > These remove comments, remove outcommented code, ...
> > > this definitly is not what indent does and its just what i quickly spotted
> > 
> > We've been over this before.  The commit message was bad, it has been
> > fixed.  You can hardly accuse Uoti of writing bad commit messages in
> > general.
> 
> The commit was bad and i suspect that was because uoti did not review what
> he commited before he commited it.
> Otherwise why would he have missed that it was not just a reindentation?

Uoti did not expect a commit that mixes different kinds of cosmetic
changes to cause such a commotion.  He made a mistake, it got fixed.
So let's cut his head off, shall we?

Why are we discussing this for the nth time?  Nothing to see here really,
move on.

> > > And thats why such commits are so bad and why we all complain, they are a
> > > nightmare to review, you missed the things above, others missed them too.
> > 
> > I posted a diff without whitespace changes to this thread.  It was not
> > at all hard to review.  Move on, nothing to see here...
> 
> you posted a >40k diff -uwbBE
> This diff was still 90% whitespace changes and very hard to review, the
> mere size showed that.

I had no trouble reviewing it.  I just did it *again*, it took me about
5 minutes.

There's a simple solution for the future: Get it over with and reindent
all of MPlayer.

> > > Besides demuxer.c is not maintained by uoti ...
> > 
> > Other files were reindented without a big outcry before.
> 
> * which files where reindented without spoken or unspoken approval of the
>   maintainer?

We've already discussed this before.

------------------------------------------------------------------------
r24911 | uau | 2007-11-01 07:51:38 +0100 (Thu, 01 Nov 2007) | 4 lines
Changed paths:
   M /trunk/libmpcodecs/dec_audio.c

Reindent dec_audio.c

Also remove some commented out code
------------------------------------------------------------------------

No trouble caused by this.

> * demuxer.c was NOT just reindented, comments and outcommented code was
>   removed as well.

You are repeating yourself.  All the changes were cosmetic changes.  We
have discussed all of this before.

Diego