[MPlayer-cvslog] r27106 - trunk/playtree.c

Aurelien Jacobs aurel at gnuage.org
Sat Jun 21 00:50:00 CEST 2008


Benjamin Zores wrote:

> Aurelien Jacobs a écrit :
> > ben wrote:
> > 
> >> Author: ben
> >> Date: Fri Jun 20 21:51:43 2008
> >> New Revision: 27106
> >>
> >> Log:
> >>
> >> Only "pop" subtree params if they had previously been "pushed",
> >> and afterwards reset the "pushed" value to 0 again.
> >> Similarly only set the PLAY_TREE_RND_PLAYED flag
> >> if the entry had been pushed before.
> > 
> > This patch patch was already submitted and rejected long time ago:
> > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2003-August/020356.html
> > 
> > Somewhat later, it was revived, with the same conclusion (unacceptable):
> > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/053873.html
> > 
> > What makes you so confident that this patch is now OK (to the point that
> > you don't even dare to discuss it before commit) ?
> 
> Using it on geexbox (but you're aware of that !!) for years without any 
> trouble ?

The fact that it don't cause trouble in the very specific geexbox case don't
make it good for every use case on any platform.

Anyway, committing a patch that was explicitly rejected by the maintainer
of the concerned code, without any notice, and without any explanation
why the maintainer was wrong, is pretty harsh.

Aurel



More information about the MPlayer-cvslog mailing list