[MPlayer-cvslog] r26219 - trunk/mpbswap.h

[Diego Biurrun]

On Wed, Mar 12, 2008 at 09:20:58AM +0100, Reimar Döffinger wrote:
> On Wed, Mar 12, 2008 at 12:40:08AM +0100, Diego Biurrun wrote:
> > On Tue, Mar 11, 2008 at 11:42:48AM +0100, Reimar Döffinger wrote:
> > > On Mon, Mar 10, 2008 at 09:20:08PM +0100, diego wrote:
> > > > 
> > > > Log:
> > > > Add missing header #include.
> > > > 
> > > > --- trunk/mpbswap.h	(original)
> > > > +++ trunk/mpbswap.h	Mon Mar 10 21:20:08 2008
> > > > @@ -3,6 +3,8 @@
> > > >  
> > > >  #include <sys/types.h>
> > > >  #include "libavutil/bswap.h"
> > > > +#include "config.h"
> > > 
> > > Uh, libavutil/bswap.h almost certainly requires config.h, this seems
> > > like a stupid place to put it?
> > 
> > The whole point is to get rid of magic header order requirements...
> 
> That is no reason to just put them in some random place instead of
> having some kind of system to give it a consistent look.

I never stated anything to the contrary.

> Not to mention that others have given reasons why it is a good idea to
> place config.h at least before all non-system headers (makes it easy to
> put system specific hacks in config.h - sure we may never accept such
> hacks in SVN, but is there a single advantage to _not_ preferring a
> specific placement of config.h include?)

That sounds more like a (good) reason to put config.h before all other
#includes, even system #includes.  After all you might want to put
things like _GNU_SOURCE or _ISOC9X_SOURCE or other system-specific
definitions in there.

Diego