[MPlayer-cvslog] r27994 - trunk/libvo/vo_wii.c

[Diego Biurrun]

On Sun, Nov 23, 2008 at 04:00:53PM +0100, Reimar Döffinger wrote:
> On Sun, Nov 23, 2008 at 02:42:41PM +0100, diego wrote:
> > 
> > Log:
> > Merge if condition check to lessen differences to vo_fbdev.c.
> > 
> > --- trunk/libvo/vo_wii.c	(original)
> > +++ trunk/libvo/vo_wii.c	Sun Nov 23 14:42:41 2008
> > @@ -234,9 +234,7 @@ static int config(uint32_t width, uint32
> >      mp_msg(MSGT_VO, MSGL_ERR, "Can't open %s: %s\n", TTY_DEV_NAME, strerror(errno));
> >      vt_doit = 0;
> >    }
> > -
> > -  vt_fp = fdopen(vt_fd, "w");
> > -  if (vt_doit && !vt_fp) {
> > +  if (vt_doit && !(vt_fp = fdopen(vt_fd, "w"))) {
> 
> Uh, these are not the same, one was broken (I suspect you actually fixed
> a possible file descriptor leak, please adjust the commit message.
> But I still think there is something seriously broken about this,
> vt_doit is never again set to 1 again, so either these vos keep the file
> open forever, even when they are not used or the will not be able to
> play more than one file without -fixed-vo.

I'm not sure I understand what exactly you want me to do: Keep, revert
or just adjust commit message?  Do you have a good suggestion for the
latter?

Diego