[MPlayer-cvslog] r27822 - trunk/libmpcodecs/vf_palette.c

Michael Niedermayer michaelni at gmx.at
Mon Oct 27 13:21:08 CET 2008

On Sun, Oct 26, 2008 at 02:19:30PM +0200, Uoti Urpala wrote:
> On Sun, 2008-10-26 at 12:54 +0100, Michael Niedermayer wrote:
> > On Sat, Oct 25, 2008 at 02:07:59AM +0200, uau wrote:
> > > vf_palette: Fix compilation after libswscale API changes
> > > 
> > > Patch from Guillaume Poirier. 
> > 
> > > I didn't test the functionality of the
> > > filter but at least it fixes compilation.
> > 
> > right, dont bother, just commit the first best change that makes things
> > compile. Who needs working code anyway ...
> Making the whole MPlayer compile is a lot more important than the
> functionality of a little used filter. Even if it it was known _not_ to
> work correctly fixing compilation would still take priority.

i agree but why in gods f* sake could you not simply have attempted to
asked/waited for someone who knows the code?
Or if not (or the hypothetical case of noone awnsering) at least have
put a printf/mp_msg() in there saying that the code might not be correct.

As it is (if it would be left that way) someone might eventually spend alot
of time debuging a "wrong color" bug.

> Feel free to test the functionality of the filter as much as you like.
> My actions were still better than those of any developer who left
> compilation broken, which includes you. So your flaming is misguided.

Sorry but i was not aware of the swscale change breaking compilation
before i saw your commit. Had you attempted to contact me or waited until
ive read mplayer-dev i would have fixed it properly.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20081027/f1afbbdd/attachment.pgp>

More information about the MPlayer-cvslog mailing list