[MPlayer-cvslog] r27822 - trunk/libmpcodecs/vf_palette.c

[Michael Niedermayer]

On Mon, Oct 27, 2008 at 07:22:45PM +0100, Diego Biurrun wrote:
[...]
> > > Feel free to test the functionality of the filter as much as you like.
> > > My actions were still better than those of any developer who left
> > > compilation broken, which includes you. So your flaming is misguided.
> > 
> > Sorry but i was not aware of the swscale change breaking compilation
> > before i saw your commit. Had you attempted to contact me or waited until
> > ive read mplayer-dev i would have fixed it properly.
> 
> Well, maybe you can tell us if this filter still makes any sense or
> should just be removed.

I think that vf_scale should be able to handle things fine and palette
probably is redundant. vf scale might need a PAL pix fmt added to a list
though ...
but i did not test this at all, if someone does test it and it works then
i certainly support droping vf_palette


> 
> If you want to fix things properly, there is a patch for vf_smartblur on
> dev-eng.  It's one of your filters and it is currently broken.

patch reviewed, though i must say you complain quick, the patch was sent
a few hours ago

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20081027/2d293493/attachment.pgp>