[MPlayer-cvslog] r27849 - trunk/libvo/x11_common.c

[Andrew Savchenko]

Hi,

On Friday 31 October 2008 07:32, Uoti Urpala wrote:
[...]

> Do you have evidence that enabling backing store gives a
> noticeable benefit in _any_ xserver version?

No, but neither do you have an evidence that disabled backing store 
is usefull on xorg < 1.5.0. Well, there is a very little evidence 
that it may improve performance in some cases in the first mail of 
original tread in mplayer-dev ML.

> I've only seen evidence that it's harmful in some cases and makes 
> no difference in others.

It is harmful only for newer versions of xorg >= 1.5.0. We have not 
enough creditable data to talk about its usefullness or 
uselessness for older versions. Due to this fact I argue to leave 
things as is for old versions for safety measures and change it 
only for new versions of X server. IOW my proposition is just to 
add an appropriate configure check and #ifdef closure. I do not 
propose to remove this at all.

-- 
Best regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20081031/6482894d/attachment.pgp>