[MPlayer-cvslog] r27550 - in trunk: libmpdemux/demux_mkv.c mpcommon.c

Uoti Urpala uoti.urpala at pp1.inet.fi
Tue Sep 9 22:24:35 CEST 2008

On Tue, 2008-09-09 at 09:11 +0200, Reimar Döffinger wrote:
> That is not an acceptable commit message. If it needs such a long
> explanation, explain it on the mailing list and reference the mail, but
> commit messages are supposed to be messages, not whole reference books.

"Not acceptable" why? You mention no reason except length, but while
longer than average this is not an exceptionally long message (except
perhaps in MPlayer history, but I hope you don't use traditional MPlayer
practices as examples of how things should be done :) ). If the
explanation is not bad in itself then it should be in the commit
message, not linked from some mailing list archive which might not even
exist later when someone reads the history.

You don't even give any reason why you'd prefer shorter messages.
Skipping over long messages should be easy if you don't want to read
them completely, much easier than skipping over simple changes split
into unnecessarily many commits which you don't usually complain about.

More information about the MPlayer-cvslog mailing list