[MPlayer-cvslog] r27561 - in trunk/libswscale: swscale.c swscale_template.c

Uoti Urpala uoti.urpala at pp1.inet.fi
Sat Sep 13 01:59:41 CEST 2008


On Wed, 2008-09-10 at 01:30 +0200, michael wrote:
> Author: michael
> Date: Wed Sep 10 01:30:06 2008
> New Revision: 27561


> Modified: trunk/libswscale/swscale_template.c
> ==============================================================================
> --- trunk/libswscale/swscale_template.c	(original)
> +++ trunk/libswscale/swscale_template.c	Wed Sep 10 01:30:06 2008
> @@ -1875,78 +1875,121 @@ static inline void RENAME(bgr32ToUV)(uin
>      }
>  }
>  
> -static inline void RENAME(bgr24ToY)(uint8_t *dst, uint8_t *src, long width)
> -{
>  #ifdef HAVE_MMX
> +static inline void bgr24ToY_mmx(uint8_t *dst, uint8_t *src, long width, int srcFormat)

This causes a build failure with runtime cpudetection enabled because
the new function has no RENAME and will be redefined when the template
file is included again (first for plain MMX, then for MMX2 which has
HAVE_MMX defined too).

The reason this breakage isn't visible under FFmpeg is that its
buildsystem never defines RUNTIME_CPUDETECT in which case swscale.c only
builds the MMX2 version. I guess this isn't desired behavior either?




More information about the MPlayer-cvslog mailing list