[MPlayer-cvslog] r29123 - trunk/libmpdemux/parse_mp4.c

[Diego Biurrun]

On Thu, Apr 02, 2009 at 10:37:47AM +0200, Reimar Döffinger wrote:
> On Wed, Apr 01, 2009 at 07:09:12PM +0200, Diego Biurrun wrote:
> > On Wed, Apr 01, 2009 at 07:48:32PM +0300, Uoti Urpala wrote:
> > > On Wed, 2009-04-01 at 18:28 +0200, diego wrote:
> > > > 
> > > > Log:
> > > > Add config.h #include, necessary for HAVE_MALLOC_H check.
> > > 
> > > You should first verify whether the check is correct and needed - as far
> > > as I can tell it isn't.
> > 
> > How can the test be incorrect and unneeded?  malloc.h is not available
> > everywhere..
> 
> I think the point is that the file only uses malloc and free, and I
> don't think any systems need malloc.h for that, only e.g. memalign
> should need malloc.h but parse_mp4.c does not use that.

OK, that makes sense.  I'll remove the #include from files not using
memalign.

Diego