[MPlayer-cvslog] r29132 - in trunk: Makefile libaf/af.c libaf/af_bs2b.c

[Reimar Döffinger]

On Thu, Apr 02, 2009 at 09:01:57PM +0200, bircoph wrote:
> +#ifdef WORDS_BIGENDIAN
> +                af->play = play_fbe;
> +#else
> +                af->play = play_fle;
> +#endif //WORDS_BIGENDIAN

Sorry for noticing only now, but what "nonsense" is that with
little/bigendian float?
It's maybe more theoretical, but the endianness of float values is not
necessarily the same as for int values, and WORDS_BIGENDIAN only covers
the int values (in that light, maybe even AF_FORMAT_FLOAT_NE itself is a
bit questionable).
It might ease portable use of the bs2b library if it provided a function to
process samples in native float format, particularly should there be any
systems in existence that use "middle-endian" for floats.
Btw. I think MPlayer still uses mostly /* */ comments after preprocessor
("#endif") stuff. Not sure if there is still a point in it, but some
compilers (which probably combined a almost-C99 compiler with a C89
preprocessor) complained about // comments as unexpected stuff after it
(only warnings though).