[MPlayer-cvslog] r29140 - trunk/version.sh

[Carl Eugen Hoyos]

Uoti Urpala <uoti.urpala <at> pp1.inet.fi> writes:

> > > Why did you commit this partial check fix if you were going to post a
> > > patch which removes it a few minutes later?
> 
> > What makes it "partial"?
> 
> It doesn't compare the whole file.

And in which situation does this make a difference? You mean in case the file
system is corrupt, but still allows compilation of the complete MPlayer tree?

> > I'm not sure I prefer the new patch, Carl Eugen
> 
> Then you should have waited for that to be decided first.

Your vote might be welcome.

> The larger-than-necessary rebuilds were not such a serious issue

We clearly disagree here.

Note that I did neither commit "something" nor "anything", but an approved patch
that fixed the problem (that can be fixed differently as well).

Carl Eugen