[MPlayer-cvslog] r30100 - trunk/libmpdemux/demux_lavf.c

[Reimar Döffinger]

On Mon, Dec 28, 2009 at 01:23:42AM +0000, Carl Eugen Hoyos wrote:
> compn <tempn <at> twmi.rr.com> writes:
> 
> > >Log:
> > >Do not use correct-pts by default for demuxer lavf, it breaks all PAFF files.
> > 
> > this makes some mp4 files play in 'fast forward'
> > sample: incoming/8mb.mp4
> 
> Following inlined patch fixes it (a PAFF in mov sample is attached to issue 944).
> 
> I'll apply if nobody objects, Carl Eugen
> 
> Index: libmpdemux/demux_lavf.c
> ===================================================================
> --- libmpdemux/demux_lavf.c     (revision 30131)
> +++ libmpdemux/demux_lavf.c     (working copy)
> @@ -612,6 +612,11 @@
>      lavf_priv_t *priv = demuxer->priv;
> 
>      switch (cmd) {
> +        case DEMUXER_CTRL_CORRECT_PTS:
> +           if (!strcmp("mov,mp4,m4a,3gp,3g2,mj2", priv->avif->name))
> +               return DEMUXER_CTRL_OK;
> +           else
> +               return DEMUXER_CTRL_NOTIMPL;

I'm not sure this is a good idea, there were similar issues with flv
IIRC.
If the only think you could find an issue with is mkv files, IMO only
disable correct-pts only for mkv (though in that case I have to wonder
if there isn't something wrong with the mkv demuxer).
But I have some doubts this really depends on the container format...