[MPlayer-cvslog] r23335 - in trunk: configure vidix/Makefile

Diego Biurrun diego at biurrun.de
Wed Feb 4 12:31:51 CET 2009


On Wed, Feb 04, 2009 at 09:16:53AM +0100, Attila Kinali wrote:
> On Thu, 17 May 2007 23:48:56 +0200 (CEST)
> diego <subversion at mplayerhq.hu> wrote:
> > 
> > Log:
> > Remove awk test.  awk is a basic Unix tool, any implementation is sufficient.
> 
> Diego, I asked you already twice to revert this patch, because it breaks
> solaris.

This commit does not break Solaris and reverting it would not fix
Solaris.  Solaris users need to add /usr/xpg4/bin to their path and use
the POSIX-compatible system tools instead of the broken ones.

This is now clearly documented and the reporter of bug #1397 was happy
with that.

awk is not the only problem.  Solaris grep and sh are also unusable,
possibly more tools are affected.  I refuse to clutter the build system
with workarounds for this situation, when the situation can be cleanly
resolved by well-documented and well-known procedures.

Adding back awk detection would not make MPlayer build with the default
Solaris system tools.  Much more work would be needed and the time spent
on such workarounds would be wasted.  There is a simple and clean
solution available: Adjust the path on Solaris.

POSIX-compatible system tools and GNU Make are a strict requirement for
building MPlayer.  These requirements are entirely reasonable and
available on all operating systems that MPlayer has a chance to run on.
I will not accept cluttering the build system with hacks to weaken these
requirements.

This decision is final as long as I maintain the build system.

Diego



More information about the MPlayer-cvslog mailing list