[MPlayer-cvslog] r28331 - in trunk/libmpcodecs: ad_hwac3.c native/rtjpegn.c vd_ffmpeg.c vf.c vf_scale.c

[Guillaume POIRIER]

Hello,

On Fri, Jan 16, 2009 at 11:28 AM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Fri, Jan 16, 2009 at 11:07:14AM +0100, gpoirier wrote:
>> Author: gpoirier
>> Date: Fri Jan 16 11:07:14 2009
>> New Revision: 28331
>>
>> Log:
>> fix compilation on non x86 machines (PPC here)
>>
>> Modified:
>>    trunk/libmpcodecs/ad_hwac3.c
>>    trunk/libmpcodecs/native/rtjpegn.c
>>    trunk/libmpcodecs/vd_ffmpeg.c
>>    trunk/libmpcodecs/vf.c
>>    trunk/libmpcodecs/vf_scale.c
>>
>> Modified: trunk/libmpcodecs/ad_hwac3.c
>> ==============================================================================
>> --- trunk/libmpcodecs/ad_hwac3.c      Fri Jan 16 10:44:36 2009        (r28330)
>> +++ trunk/libmpcodecs/ad_hwac3.c      Fri Jan 16 11:07:14 2009        (r28331)
>> @@ -179,7 +179,7 @@ static int decode_audio(sh_audio_t *sh_a
>>      buf16[2] = 0x0001;   // data-type ac3
>>      buf16[2] |= (sh_audio->a_in_buffer[5] & 0x7) << 8; // bsmod
>>      buf16[3] = len << 3; // number of bits in payload
>> -#ifdef WORDS_BIGENDIAN
>> +#if WORDS_BIGENDIAN
>
> Uh, these are all wrong:
> #undef WORDS_BIGENDIAN
> it is never defined as 0.

Ah, you're right.


>> Modified: trunk/libmpcodecs/native/rtjpegn.c
>> ==============================================================================
>> --- trunk/libmpcodecs/native/rtjpegn.c        Fri Jan 16 10:44:36 2009        (r28330)
>> +++ trunk/libmpcodecs/native/rtjpegn.c        Fri Jan 16 11:07:14 2009        (r28331)
>> @@ -33,7 +33,7 @@
>>  #include "mpbswap.h"
>>  #include "rtjpegn.h"
>>
>> -#ifdef MMX
>> +#if MMX
>
> These are wrong, too, this is not HAVE_MMX.

Correct too.

How should i fix that? Should I apply attached patch or revert my changes?

Guillaume
-- 
Only a very small fraction of our DNA does anything; the rest is all
comments and ifdefs.

Bob Hope  - "I grew up with six brothers. That's how I learned to
dance - waiting for the bathroom."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MMX_WORDS_BIGENDIAN.diff
Type: application/octet-stream
Size: 23901 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20090116/d6195f22/attachment.obj>