[MPlayer-cvslog] r29456 - in trunk: etc/codecs.conf libmpdemux/mp_taglists.c

[Diego Biurrun]

On Thu, Jul 30, 2009 at 11:39:11AM +0200, Nico Sabbi wrote:
> On Thursday 30 July 2009 11:35:19 Dominik 'Rathann' Mierzejewski 
> wrote:
> > On Thursday, 30 July 2009 at 11:12, Nico Sabbi wrote:
> > > On Thursday 30 July 2009 11:03:34 Diego Biurrun wrote:
> > > > On Thu, Jul 30, 2009 at 10:36:17AM +0200, nicodvb wrote:
> > > > > Log:
> > > > > added inexistant TRHD fourcc to handle TRUEHD streams in
> > > > > forthcoming patch
> > > >
> > > > This is the wrong way around.  Now we have a revision that
> > > > claims to support a feature but doesn't.
> > >
> > > but the other way around would have used an inexistant fourcc
> >
> > Why didn't you do it in one commit then?
> 
> they are quite indipendent on each other: the former patch  makes 
> available a new fourcc, the latetr one uses it.
> Aso, I acted similarly in the past without complaints, so I considered 
> safer and better doing the same. If you prefer we can revert and 
> recommit.

No, don't bother, just remember it for the future.

Diego

P.S.: extra good karma for trimming quotes