[MPlayer-cvslog] r29026 - trunk/libvo/vo_vdpau.c

Carl Eugen Hoyos cehoyos at ag.or.at
Sun Mar 22 00:01:03 CET 2009

Uoti Urpala <uoti.urpala <at> pp1.inet.fi> writes:

> > -        && create_vdp_decoder(max_refs) < 0)
> > +        && !create_vdp_decoder(max_refs))
> IMO the previous version was better. I think the most consistent rule is
> that functions named "do_xyz" (which this is clearly one of) should
> return a negative error code if they fail to do xyz.

I don't have any strong opinion on this, but since this clearly simplifies
calling create_vdp_decoder() and I have been specifically asked to do this
change, I'll only revert if there is general consensus.

Thank you, Carl Eugen

More information about the MPlayer-cvslog mailing list