[MPlayer-cvslog] r29839 - trunk/mplayer.c

Michael Niedermayer michaelni at gmx.at
Sat Nov 7 19:19:54 CET 2009


On Fri, Nov 06, 2009 at 09:27:20PM +0200, Uoti Urpala wrote:
> On Fri, 2009-11-06 at 17:06 +0100, reimar wrote:
> > Log:
> > Simplify: use &= instead of a = b & a;
> 
> > -  mask=initialized_flags&mask;
> > +  mask &= initialized_flags;
> 
> Stuff like this would be better combined into one commit together with
> other trivial changes. 

That is your oppinon, its for example not my oppinion and i would suspect
its also not reimars oppinion otherwise he likely wouldnt have commited it
like that.
Of course one could commit things together, its not the end of the world
but i thought as you have your private fork already you would apply your
ideas to it and the rest of the world would apply their ideas to their
stuff.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20091107/6184e4ef/attachment.pgp>


More information about the MPlayer-cvslog mailing list