[MPlayer-cvslog] r31015 - trunk/libvo/vo_corevideo.m

[Diego Biurrun]

On Mon, Apr 05, 2010 at 12:30:37PM -0400, Alexander Strange wrote:
> 
> On Apr 5, 2010, at 3:33 AM, Reimar Döffinger wrote:
> 
> > On Mon, Apr 05, 2010 at 09:22:21AM +0200, reimar wrote:
> >> 
> >> Log:
> >> Enable OSD also for BGR32, the code is the same as for RGB32.
> > 
> > Could someone please test with -vf format=rgb32 and -vf format=bgr32
> > on an Intel MAC?
> > On PPC, only bgr32 gives correct colours, and on Intel at most one
> > can work, but I'm almost certain neither does.
> > If all other OS X code is as well implemented (the normal playback
> > case involves one colourspace conversion and a memcpy - vo gl does
> > not require either so it's faster than it despite the extra effort
> > of going through X) and tested as this it's no surprise MPlayer
> > sucks big time on OS X.
>
> I sent a patch to remove the memcpy years ago but the maintainer
> claimed to not see any change, although I remember it being quite
> significant. On the other hand, the patch was probably broken now that
> I think about it.

Please resend it and let Reimar have a look :)

Diego