[MPlayer-cvslog] r31074 - in trunk: Makefile libvo/gl_common.c libvo/sdl_common.c libvo/sdl_common.h libvo/vo_sdl.c

[Diego Biurrun]

On Sun, Apr 25, 2010 at 10:17:23AM +0200, reimar wrote:
> 
> Log:
> Add sdl_common file and use it to share the input handling between -vo gl
> with SDL backend and -vo sdl.

neat

some nits below

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ trunk/libvo/sdl_common.c	Sun Apr 25 10:17:23 2010	(r31074)
> @@ -0,0 +1,112 @@
> +
> +        if(vo_nomouse_input)
> +
> +        if(vo_nomouse_input)
> +
> +        switch(keypressed) {

K&R places a space between keywords and '('.

> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ trunk/libvo/sdl_common.h	Sun Apr 25 10:17:23 2010	(r31074)
> @@ -0,0 +1,32 @@
> +
> +#ifndef MPLAYER_SDL_COMMON_H
> +#define MPLAYER_SDL_COMMON_H
> +
> +#endif

missing #endif comment

Diego