[MPlayer-cvslog] r31100 - trunk/libvo/x11_common.c

[Diego Biurrun]

On Wed, Apr 28, 2010 at 09:16:37PM +0200, Reimar Döffinger wrote:
> On Wed, Apr 28, 2010 at 01:08:08PM +0200, Diego Biurrun wrote:
> > On Wed, Apr 28, 2010 at 10:57:37AM +0000, Carl Eugen Hoyos wrote:
> > > Diego Biurrun <diego <at> biurrun.de> writes:
> > > 
> > > > > Doesn't this break compilation with gcc-2.95?
> > > > 
> > > > Compilation with gcc 2.95 has been broken for years already BTW..
> > > 
> > > Works fine with --disable-ass --disable-ass-internal --disable-win32dll
> > > --disable-sse, not affected by r31100.
> > > (disable-ass-internal alone is broken for any compiler)
> > > 
> > > win32dll should probably be fixed, the rest autodetected.
> > 
> > To be honest, the fact that nobody noticed nor cared to fix it for such
> > a long time is more of an indication that nobody cares in the first
> > place.  I certainly don't care anymore.
> 
> I noticed, but I considered libass "non-fixable" since we are no
> longer upstream and I don't really want us to accumulate that kind
> of patches.

I completely agree with you.  But the main question remains open: What
about certain vintage compiler versions for which we already disable
large parts of MPlayer?

Diego