[MPlayer-cvslog] r32009 - in trunk: eosd.c eosd.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Aug 24 08:15:11 CEST 2010


On Tue, Aug 24, 2010 at 03:16:54AM +0200, Diego Biurrun wrote:
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ trunk/eosd.h	Mon Aug 23 21:22:03 2010	(r32009)
> > @@ -0,0 +1,33 @@
> > +
> > +void eosd_init(vf_instance_t *);
> > +
> > +void eosd_configure(mp_eosd_res_t *, int);
> > +ASS_Image *eosd_render_frame(double, int *);
> > +void eosd_uninit(void);
> > +
> > +void eosd_ass_init(ASS_Library *);
> 
> I consider leaving out the variable names bad style.

For consistency and documentation purposes I agree
that is better.
Particularly since you should also add doxygen documentation
and I'm not sure that will work without having the names
here as well :-)


More information about the MPlayer-cvslog mailing list