[MPlayer-cvslog] r32015 - in trunk: eosd.c eosd.h

[Reimar Döffinger]

On Sun, Aug 29, 2010 at 12:52:00PM +0200, Diego Biurrun wrote:
> On Thu, Aug 26, 2010 at 01:20:51PM +0200, cigaes wrote:
> > 
> > Log:
> > Add #ifdefs to fix build with ASS disabled.
> 
> This message does not match ..
> 
> > --- trunk/eosd.h	Wed Aug 25 18:34:39 2010	(r32014)
> > +++ trunk/eosd.h	Thu Aug 26 13:20:50 2010	(r32015)
> > @@ -25,9 +25,9 @@
> >  
> >  void eosd_configure(mp_eosd_res_t *, int);
> > -ASS_Image *eosd_render_frame(double, int *);
> > +struct ass_image *eosd_render_frame(double, int *);
> >  void eosd_uninit(void);
> >  
> > -void eosd_ass_init(ASS_Library *);
> > +void eosd_ass_init(struct ass_library *);
> 
> .. these changes.
> 
> Why did you mix independent changes in one commit?  You should never do
> this and now you should at least update the commit message.

Well, they were both compilation fixes for the case where ASS is disabled,
and both were small, so I think having the together is ok, but it's
not so good that the commit message only matches half the commit.