[MPlayer-cvslog] r32724 - trunk/configure

[Reimar Döffinger]

On 23 dec 2010, at 13:04, Diego Biurrun <diego at biurrun.de> wrote:

> On Wed, Dec 22, 2010 at 05:37:13PM +0100, Reimar Döffinger wrote:
>> On 22 dec 2010, at 12:47, Diego Biurrun <diego at biurrun.de> wrote:
>> 
>>> On Sun, Dec 19, 2010 at 11:02:53PM +0100, reimar wrote:
>>>> 
>>>> Log:
>>>> Compilation fixes for currentl Cygwin.
>>>> 
>>>> --- trunk/configure    Sun Dec 19 15:19:04 2010    (r32723)
>>>> +++ trunk/configure    Sun Dec 19 23:02:52 2010    (r32724)
>>>> @@ -1519,6 +1519,12 @@ if win32 ; then
>>>> 
>>>> +if cygwin ; then
>>>> +  # e.g. priority.c needs _WIN32 define, but
>>>> +  # latest cygwin no longer defines it
>>>> +  extra_cflags="-D_WIN32 $extra_cflags"
>>>> +fi
>>> 
>>> Do we need the _WIN32 #define at all?  Some other places assume that
>>> Cygwin behaves different from _WIN32, for example
>>> 
>>> ./configure:#if !defined(_WIN32) || defined(__CYGWIN__)
>>> ./vidix/pci.c:#elif defined (_WIN32) || defined(__CYGWIN__)
>>> 
>>> It seems to me we should rather fix priority.c.
>> 
>> If the fix means adding a extra check for the cygwin define: no, it's not my goal to add useless code.
>> Also it would be inconsistent, win32 in configure is both mingw and cygwin.
> 
> No adding of useless code is necessary:
> 
> diffstat win32.diff
> configure                      |    8 +-------
> libdvdread4/dvd_reader.c       |   10 +++++-----
> libdvdread4/dvdread_internal.h |    5 +----
> 3 files changed, 7 insertions(+), 16 deletions(-)
> 
> Could you please test my patch on a Cygwin system?

Not yet tested, but that misses a fix for the priority.c file that caused the issue in the first place.
Also older cygwin versions defined _win32 - I think I am fine with dropping support for them but at least that second configure change should be applied separately for that reason.
>