[MPlayer-cvslog] r30182 - in trunk: Makefile configure libvo/matrixview.c libvo/matrixview.h libvo/matrixview_font.h libvo/video_out.c libvo/vo_matrixview.c

[Diego Biurrun]

On Mon, Jan 04, 2010 at 01:32:36PM +0100, Reimar Döffinger wrote:
> On Mon, Jan 04, 2010 at 01:07:17PM +0100, Diego Biurrun wrote:
> > > > > + * MatrixView is distributed in the hope that it will be useful,
> > > > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > > > + * GNU General Public License for more details.
> > > > > + *
> > > > > + * You should have received a copy of the GNU General Public License along
> > > > > + * with MPlayer; if not, write to the Free Software Foundation, Inc.,
> > > > > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > > > > + */
> > > > 
> > > > MatrixView or MPlayer?  It should be the latter.
> > > 
> > > That code is basically from MatrixView, so I avoided changing it.
> > 
> > MatrixView wrote MPlayer in their license header?
> 
> No, I only changed that part because it seemed risk-free (and had the
> incorrect FSF address anyway).
> I'd appreciate if you just do whatever changes you consider appropriate.

Done.

> > > > missing license header
> > > 
> > > Grumml... 100% non-copyrightable... grumml... I won't get around it no
> > > matter how much I grumml, will I?
> > 
> > It's not copyrightable *today*, but tomorrow it will me moved around,
> > merged, extended and converted into something copyrightable.  So no, I
> > do not think there is a way around license headers for all new files.
> > And yes, I will eventually add them to all the ones that still lack one.
> 
> Can we have some file like "licenseheader.txt" or such in MPlayer?
> So we can just cat that in front without risk of copying from the only
> file that has a bad/outdated/whatever one?

I have fixed all license headers already, so there is no risk of copying
a wrong one. Of course, some files still lack license headers. Would it
be enough to add license headers to all files?

Diego