[MPlayer-cvslog] r31641 - trunk/configure

[Diego Biurrun]

On Tue, Jul 06, 2010 at 07:17:21PM +0200, Reimar Döffinger wrote:
> On Tue, Jul 06, 2010 at 12:18:09PM +0200, Diego Biurrun wrote:
> > On Mon, Jul 05, 2010 at 11:41:50PM +0200, Reimar Döffinger wrote:
> > > On Mon, Jul 05, 2010 at 11:34:52PM +0200, diego wrote:
> > > > 
> > > > Log:
> > > > Move libgsm #define to the FFmpeg section of config.h.
> > > 
> > > When I added libgsm support I also noticed that in
> > > config.mak all those CONFIG_LIB*CODER stuff should appear twice,
> > > since we have auto-generation for the decoder/encoder variables
> > > but some are also explicitly there.
> > > Could you have a look if I'm right?
> > 
> > I'm not following, what is the problem and what do you want me to
> > investigate?
> 
> $ grep CONFIG_LIBOPENJPEG_DECODER configure config.mak 
> configure:CONFIG_LIBOPENJPEG_DECODER       = $libopenjpeg
> config.mak:CONFIG_LIBOPENJPEG_DECODER       = yes
> config.mak:CONFIG_LIBOPENJPEG_DECODER=yes
> 
> Seems a bit overkill to have them twice in config.mak.
> However, only one is generated manually, so the other one
> must have been created automatically.
> However
> configure:CONFIG_LIBOPENCORE_AMRNB_DECODER = $_libopencore_amrnb
> config.mak:CONFIG_LIBOPENCORE_AMRNB_DECODER = no
> 
> So for AMR for some reason there is non auto-generated...
> This seems very messed-up to me.

OK, now I get what you mean.  Fixed.

Diego