[MPlayer-cvslog] r31310 - trunk/libvo/vo_yuv4mpeg.c

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Jun 3 21:16:20 CEST 2010

On Thu, Jun 03, 2010 at 07:37:58PM +0200, siretart wrote:
> Author: siretart
> Date: Thu Jun  3 19:37:58 2010
> New Revision: 31310
> Log:
> vo_yuv4mpeg: disable RGB support when compiling against a shared libswscale
> This avoids using swscale internals when compiling against a shared libswscale.

This kind of hack certainly isn't user-friendly at all.
And this particular way is just plain broken, it will accept RGB and write
it as YUV.
If you don't understand the code (and/or can't be bothered to try first),
at least send a patch for review first.

> Patch inspired by Uoti Urpala's work in his git branch:
> http://repo.or.cz/w/mplayer.git/commitdiff/cd4e8dc1fa2863dcce62a44dd9ea105f9f9288f4

Well, he at least did it right, though understand what the code does, then either
figuring out and documenting a way to do the same with video filters or alternatively
fixing it to work with the proper swscale API sure is a far better solution.

More information about the MPlayer-cvslog mailing list