[MPlayer-cvslog] r31359 - in trunk: configure libmpcodecs/vd_libmpeg2.c libmpeg2/header.c libmpeg2/libmpeg2_changes.diff libmpeg2/slice.c

[Ivan Kalvachev]

On 6/10/10, diego <subversion at mplayerhq.hu> wrote:
> Author: diego
> Date: Thu Jun 10 11:52:30 2010
> New Revision: 31359
>
> Log:
> libmpeg2: Remove local quantizer scale changes related to postprocessing.
>
> Local changes to our locally forked library copy were incompatible with the
> upstream version and prevented (easily) using the upstream version instead
> of the forked copy. The md5sums of the decoded frames do not change for one
> tested sample, so apparently the code is ineffectual and thus, after some
> discussion Luca, I decided that the changes are not worth keeping.

It's good to discuss this kind of changes on the maillist not with one
single developer, to avoid confusing situations like this.

I am surprised that you fail to understand basic concepts like how
postprocessing works and that you can't even test it properly.

You need to insert postprocessing filter, like  pp, spp, fspp. The
quant info is used by these filters. Also you for best results you
need sample with less than perfect quality (aka with visible
blocking).

Without way to export quantization, libmpeg2 is pretty much crippled.

This functionality should be pushed upstream, so it could be
implemented in cleaner standard way. Then it can be replaced.