[MPlayer-cvslog] r31490 - in trunk: cfg-common.h gui/interface.c libmpcodecs/vf.h

[Diego Biurrun]

On Thu, Jun 24, 2010 at 01:59:40PM +0200, Attila Kinali wrote:
> On Mon, 21 Jun 2010 13:01:47 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Sun, Jun 20, 2010 at 08:14:29PM +0200, Attila Kinali wrote:
> > > On Sun, 20 Jun 2010 17:38:39 +0200 (CEST)
> > > diego <subversion at mplayerhq.hu> wrote:
> > > > 
> > > > Log:
> > > > Move extern declarations for vf.c variables to vf.h.
> > > 
> > > Diego, could you at least compile your code before commiting?
> > 
> > I always compile before committing.  This slipped through by way of a
> > subtle interaction of 'make checkheaders' and .d file generation.
> 
> By "compile" i mean a "make distclean; ./configure && make" cycle.
> With ccache this is more than fast enough for a final test.

It takes too long on my machine.  And it's not necessary in any case.
I carefully designed the build system so that dependency tracking works
correctly.  What tripped me up here was an obscure bug.  I will fix it
soon enough.

> I usually also use a fresh checkout where i apply the patch by
> hand to make extra sure that the to be commited patch works as
> intended and none of my other changes interfere with it.

Since I commit about two orders of magnitude more often than you do,
you will understand that this is not a work cycle that I can copy
verbatim from you while maintaining my productivity...

Diego