[MPlayer-cvslog] r31543 - in trunk: libfaad2/decoder.c libfaad2/decoder.h libfaad2/neaacdec.h libmpcodecs/ad_faad.c

[Diego Biurrun]

On Sat, Jun 26, 2010 at 07:41:09PM +0200, Reimar Döffinger wrote:
> On Sat, Jun 26, 2010 at 08:34:09PM +0300, Nikos Chantziaras wrote:
> > On 06/23/2010 09:44 PM, cehoyos wrote:
> > >Modified:
> > >    trunk/libfaad2/decoder.c
> > >    trunk/libfaad2/decoder.h
> > >    trunk/libfaad2/neaacdec.h
> > >    trunk/libmpcodecs/ad_faad.c
> > 
> > This breaks compilation with --disable-faad-internal and FAAD2 2.7:
> 
> I just realized that.
> May I suggest removing support for external FAAD?
> IIRC the only thing remaining that FFmpeg does not support is LATM, but that
> is not supported by faad either, so external faad seems completely pointless
> now...

I disagree.  What has to go away is internal FAAD support, not the
external variant.  FFmpeg still does not support everything that FAAD
does, even though most of the bonus stuff is more or less obscure.

Diego