[MPlayer-cvslog] [propchange]: r31578 - svn:log

Reinhard Tartler siretart at tauware.de
Tue Jun 29 12:23:22 CEST 2010

On Tue, Jun 29, 2010 at 10:36:56 (CEST), Carl Eugen Hoyos wrote:

> siretart <subversion <at> mplayerhq.hu> writes:
>> Property diff:
>> --- old property value
>> +++ new property value
>> @@ -1 +1 @@
>> -revert the previous to commits, but clarify the res_comment
>> +revert the previous two commits and clarify the res_comment
> This log message is still _completely_ wrong and useless and this is not about
> points and commas.

this is a revert of the previous two commit. I cannot see the wrong part
here in the first half of your sentence.

I therefore think that your 2nd comment:

> Unrelated: Could you explain the result_comment, I don't understand it.

is not unrelated at all. My understanding of the issue is explained in
Message-ID: <87r5jrmtx1.fsf at faui44a.informatik.uni-erlangen.de>.
Relevant part follows:

| Oh, now I see it. mplayer is only able to playback vp8 via libavcodec,
| so if the shared libavcodec doesn't support vp8, we have lost
| anyway. This check only ensures that the mplayer binary gets linked with
| -lvpx to satisfy libavcodecs.a's dependencies.
| I had the (wrong) understanding that mplayer would interface libvpx
| directly. Sorry for the fuzz then, I'll clarify this in a comment.

res_comment now reads
"dynamic linking to libvpx is irrelevant when using dynamic libavcodec"

the previous wording was:
"libavcodec (static) is required by libvpx, sorry"

to me, the previous wording is way more confusing than the current one,
although I'm obviously biased.

> Please fix the log message, Carl Eugen

I'd love to, but I'd need your help with the 'how'?

Reinhard Tartler, KeyID 945348A4

More information about the MPlayer-cvslog mailing list