[MPlayer-cvslog] r30870 - in trunk/loader/dshow: graph.c graph.h

[Steinar H. Gunderson]

On Tue, Mar 09, 2010 at 01:25:21PM +0100, Diego Biurrun wrote:
> system #includes should go before local #includes.

Fixed.

>> +static void FilterGraph_Destroy(FilterGraph* This)
>> +{
>> +    Debug printf("FilterGraph_Destroy(%p) called  (%d, %d)\n", This, This->refcount, GraphKeeper);
> Isn't there a dbg_printf in loader/ somewhere?

It's not in use in loader/dshow/ at least, but I could include loader/debug.h
and use it?

>> +    if (!This->vt)
>> +    {
> K&R style for new files please, i.e. keep the { on the same line...

FWIW, this is only technically a new file; it's based on allocator.c.
But fixed.

> The = could be vertically aligned.

I don't really see the point, but if that is indeed the style, so be it.
Changed.

>> +    This->interfaces[0]=IID_IUnknown;
>> +    This->interfaces[1]=IID_IFilterGraph;
> spaces around '=' please

Fixed.

>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>> +++ trunk/loader/dshow/graph.h	Tue Mar  9 13:00:30 2010	(r30870)
>> @@ -0,0 +1,38 @@
>> +#ifndef MPLAYER_GRAPH_H
>> +#define MPLAYER_GRAPH_H
> This is missing the standard license header, same for graph.c.  If it
> was written for MPlayer, it should carry MPlayer's standard license
> header.

Written for MPlayer, but based heavily upon allocator.c. You decide.

>> +#include "interfaces.h"
>> +#include "cmediasample.h"
>> +
>> +typedef struct FilterGraph FilterGraph;
> 
>> +struct FilterGraph
>> +{
> K&R style please, i.e. keep the { on the same line..

Changed.

>> +    HRESULT STDCALL ( *AddFilter )(FilterGraph* This,
> .. same here, drop the spaces inside the parentheses.

Changed.

/* Steinar */
-- 
Homepage: http://www.sesse.net/