[MPlayer-cvslog] r30897 - in trunk: DOCS/man/en/mplayer.1 cfg-common-opts.h get_path.h mencoder.c mplayer.c

[Diego Biurrun]

On Tue, Mar 16, 2010 at 08:57:29PM +0900, KO Myung-Hun wrote:
> Diego Biurrun wrote:
> > On Mon, Mar 15, 2010 at 09:30:06AM +0100, komh wrote:
> >>
> >> Log:
> >> Add -codecpath option.
> >> It allows to search binary codecs in non-standard directories.
> >> --- trunk/get_path.h	Mon Mar 15 07:39:21 2010	(r30896)
> >> +++ trunk/get_path.h	Mon Mar 15 09:30:06 2010	(r30897)
> >> @@ -24,4 +24,10 @@
> >>  
> >> +#ifdef CONFIG_WIN32DLL
> >> +extern void SetCodecPath(const char *);   // in loader/drv.c
> > 
> > Declaring this function here is wrong.  get_path.h is for functions
> > from get_path.c.  
> 
> I think so, too.
> 
> > Also, SetCodecPath is already declared in loader/drv.h
> > so you should be able to use that header instead.
> > 
> 
> Why I don't prefer to include the headers in loader into other places,
> is it can cause conflicts with OS/2 headers, maybe Windows headers as well.

We shall have to find out then.

> >> +static char *codec_path=NULL;
> > 
> > Again, this is not the right place to declare this as it's not related
> > to get_path.c.  
> 
> I agree, any suggestion ?
> 
> Frankly, I prefer the original method even though the common codes
> should be placed on both mencoder.c and mplayer.c.

I'm no longer terribly against that.  You could try mpcommon.h though.

> > A sideeffect are something like half a dozen of the
> > following warnings:
> > 
> > get_path.h:30: warning: 'codec_path' defined but not used
> > 
> 
> So do I, but I've not encounter the below warnings at all.
> 
> I'm using gcc 4.4.2.

Scratch that, seems to be some local changes in my tree.

Diego