[MPlayer-cvslog] r30935 - trunk/libmpcodecs/vd_xanim.c

[Diego Biurrun]

On Sat, Mar 20, 2010 at 11:08:52PM +0100, Reimar Döffinger wrote:
> On Sat, Mar 20, 2010 at 11:02:07PM +0100, Diego Biurrun wrote:
> > On Fri, Mar 19, 2010 at 08:25:00PM +0100, Reimar Döffinger wrote:
> > > On Fri, Mar 19, 2010 at 12:32:14AM +0100, diego wrote:
> > > > 
> > > > Log:
> > > > Reuse codec path variable used in the binary loader in the XAnim loader.
> > > 
> > > You missed the reason why I called it "ugly": the codecpath file needs
> > > to be compiled e.g. unconditionally now.
> > > Also I suspect the command-line option should be enable unconditionally or so.
> > 
> > You are right of course.
> > 
> > I propose making the code unconditional and moving it to get_path.[ch].
> > 
> > Also, I think get_path.[ch] should be renamed to path.[ch].
> 
> Given that the totally misplaced set_path_env is already there...
> get_path was meant for getting the paths to configuration files, not as
> as a dumping place for anything with the name "path" in it.
> But as said, since set_path_env which basically has the same purpose is already
> there, fine...

Implemented and file renamed.

Diego