[MPlayer-cvslog] r32624 - in trunk: TOOLS/vfw2menc.c gui/app.c gui/interface.c gui/mplayer/gtk/pl.c gui/mplayer/gtk/sb.c gui/mplayer/play.c gui/skin/font.c gui/win32/dialogs.c gui/win32/gui.c gui/win32/playlist.c g...

Diego Biurrun diego at biurrun.de
Mon Nov 15 23:19:39 CET 2010

On Sun, Nov 14, 2010 at 10:12:35AM +0100, cboesch wrote:
> Log:
> Remove most of the NULL pointer check before free all over the code

I'd appreciate if you could be a tad more verbose in commit messages.
In general a commit message should answer two questions: What and why.
This commit message only answers the former question.

NULL pointer checks before free() are unnecessary, but very common.
A few words that explain why it is safe to remove them would enlighten
the people that come after you, many of which possibly won't know that
it is safe to remove those checks.


More information about the MPlayer-cvslog mailing list