[MPlayer-cvslog] r32478 - in trunk: DOCS/tech/slave.txt command.c input/input.c input/input.h

Nicolas George nicolas.george at normalesup.org
Sun Oct 17 15:59:00 CEST 2010


Le sextidi 26 vendémiaire, an CCXIX, Reimar Döffinger a écrit :
> No need to send that in for review, I can fix it if something is wrong.

Ok.

> Though you could add "supports raw pnm and pgm (P5 and P6)" and

Done.

> "all out params may be NULL".

Not done, as it is not true. And since all the out params are necessary to
do anything with the image, I do not think any effort to make it true would
be worth it.

> And for bytes_per_pixel: "1 means 8 bit gray, 2 means 16 bit gray,
> 3 means 8 bit/component RGB, 6 means 16 bit/component RGB."

Done.

As a side note, I believe that 16 bits support is broken on little-endian.
But 16 bits PNM are non-standard anyway.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20101017/bb7665a0/attachment.pgp>


More information about the MPlayer-cvslog mailing list