[MPlayer-cvslog] r32489 - trunk/debian/daily-build.sh

[Reinhard Tartler]

On Mon, Oct 18, 2010 at 14:16:21 (CEST), Diego Biurrun wrote:

> On Sat, Oct 16, 2010 at 09:06:02AM +0200, Reinhard Tartler wrote:
>> On Fri, Oct 15, 2010 at 19:20:21 (CEST), Diego Biurrun wrote:
>> 
>> > On Thu, Oct 14, 2010 at 10:37:47AM +0200, siretart wrote:
>> >> 
>> >> Log:
>> >> add hint for building an mplayer package that uses libdvdcss at runtime instead of the internal copy
>> >> 
>> >> --- trunk/debian/daily-build.sh	Thu Oct 14 10:36:31 2010	(r32488)
>> >> +++ trunk/debian/daily-build.sh	Thu Oct 14 10:37:47 2010	(r32489)
>> >> @@ -3,6 +3,9 @@
>> >>  # wrapper around dpkg-buildpackage to generate correct changelog
>> >>  # use "debian/daily-build.sh -b" to create binary packages
>> >>  # and "debian/daily-build.sh -S" to create a source package only
>> >> +#
>> >> +# use this invocation to load system libdvdcss at runtime
>> >> +# env DEB_EXTRA_CONFIGURE_FLAGS=--disable-libdvdcss-internal debian/daily-build.sh -Ilibdvdcss
>> >
>> > I guess you can drop this again now.
>> 
>> not really. it is the -Ilibdvdcss that strips off the libdvdcss copy,
>> and I need to add it for creating the source packages for the PPA.
>> 
>> the first part is handy for testing directly created binary packages if
>> not using the PPA builders.
>> 
>> The patch that adds the check is required so that the generated source
>> packages like this don't require modification to debian/rules and still
>> build.
>
> I don't understand what you are trying to say here, but our build system
> already adds -Ilibdvdcss, but if you are building against an external
> libdvdcss, then this flag is incorrect.

-Ilibdvdcss here is not a linker flag, but is being passed to via
dpkg-buildpackage to dpkg-source. The flags tells dpkg-source to ignore
the libdvdcss directory when generating the source package. See
dpkg-source(1) for details.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4