[MPlayer-cvslog] r32035 - in branches/1.0rc4: . libmpdemux/demux_lavf.c

[Reimar Döffinger]

On Wed, Sep 01, 2010 at 12:02:46AM +0200, Aurelien Jacobs wrote:
> On Tue, Aug 31, 2010 at 07:45:29AM +0200, Reimar Döffinger wrote:
> > On Mon, Aug 30, 2010 at 10:07:34PM +0200, siretart wrote:
> > > Author: siretart
> > > Date: Mon Aug 30 22:07:34 2010
> > > New Revision: 32035
> > > 
> > > Log:
> > > Always use convergence_duration for subtitles otherwise
> > > they will stay on screen forever for ASS subtitles in mkv
> > > if no ASS renderer is used.
> > > 
> > > backport r32032 by reimar
> > 
> > Actually I noticed that only fixes non-ASS subtitles in MKV,
> > for ASS subs convergence_duration is not set.
> > We'd have to parse the end time out of the text,
> 
> Sure ! That's the only way to go.

Will you implement it?
Because honestly I am a bit annoyed that you almost attack people
who try to improve the mkv demuxer while several things are _still_
broken with lavf and I seem to be the only one trying to make it
work.

> > but I think that's ridiculous since the demuxer had the value
> > as a number originally and sprintfs it explicitly.
> 
> No, the demuxer generally don't have the subtitle display duration
> as a field. Matroska is really an exception here, but avi, nut and
> others don't have such a field.

That doesn't make it less silly to have to do a full sprintf->sscanf
roundtrip when the value we want is already there.