[MPlayer-cvslog] r32254 - trunk/mpcommon.h

[Reimar Döffinger]

On Wed, Sep 15, 2010 at 09:23:44PM +0200, Diego Biurrun wrote:
> On Wed, Sep 15, 2010 at 08:59:43PM +0200, Reimar Döffinger wrote:
> > On Wed, Sep 15, 2010 at 08:41:30PM +0200, diego wrote:
> > > 
> > > Log:
> > > Add libmpdemux/stheader #include for struct sh_video.
> > > 
> > > --- trunk/mpcommon.h	Wed Sep 15 20:34:15 2010	(r32253)
> > > +++ trunk/mpcommon.h	Wed Sep 15 20:41:30 2010	(r32254)
> > > @@ -23,6 +23,7 @@
> > >  #include "m_option.h"
> > >  #include "subreader.h"
> > >  #include "libmpdemux/demuxer.h"
> > > +#include "libmpdemux/stheader.h"
> > 
> > Did you miss all the loads of commit I made?
> > You can't include this here, it will break
> > compilation on Windows.
> 
> How do you want to see the following warnings solved:
> 
> In file included from asxparser.c:35:
> mpcommon.h:64: warning: 'struct sh_video' declared inside parameter list
> mpcommon.h:64: warning: its scope is only this definition or declaration, which is probably not what you want
> mpcommon.h:65: warning: 'struct sh_video' declared inside parameter list
> 
> There are tons of them all over the place...

just add a
struct sh_video;
instead of the include if they are too annoying.