[MPlayer-cvslog] r33266 - in trunk/gui: cfg.c cfg.h

Ingo Brückl ib at wupperonline.de
Sat Apr 23 10:16:18 CEST 2011

Diego Biurrun wrote on Mon, 18 Apr 2011 09:28:32 +0200:

> These #ifdefs around extern declarations are unnecessary.  Not only that,
> but there was an effort in the past to get rid of all of them.

What's the desired approach for an extern with typedef?

  #ifdef CONFIG_ASS
  typedef struct {
      int enabled;
      int use_margins;
      int top_margin;
      int bottom_margin;
  } gtkASS_t;

  extern gtkASS_t gtkASS;

or without #ifdef?


More information about the MPlayer-cvslog mailing list