[MPlayer-cvslog] r33888 - in trunk: Makefile gui/win32/playlist.c gui/win32/playlist.h

[Ingo Brückl]

Reimar Döffinger wrote on Sat, 30 Jul 2011 19:21:05 +0200:

> On Sat, Jul 30, 2011 at 05:38:39PM +0200, Diego Biurrun wrote:
>> On Wed, Jul 27, 2011 at 07:37:37AM +0200, Reimar Döffinger wrote:
>> >
>> > On 26 Jul 2011, at 23:28, Diego Biurrun <diego at biurrun.de> wrote:
>> >
>> > > On Fri, Jul 22, 2011 at 12:41:11AM +0200, Diego Biurrun wrote:
>> > >> On Fri, Jul 22, 2011 at 12:24:57AM +0200, diego wrote:
>> > >>>
>> > >>> --- trunk/gui/win32/playlist.c    Thu Jul 21 03:21:36 2011 (r33887)
>> > >>> +++ trunk/gui/win32/playlist.c    Fri Jul 22 00:24:57 2011 (r33888)
>> > >>> @@ -29,7 +30,7 @@
>> > >>>
>> > >>> -BOOL adddirtoplaylist(playlist_t *playlist, const char *path, BOOL recursive)
>> > >>> +bool adddirtoplaylist(playlist_t *playlist, const char *path, bool recursive)
>> > >>> {
>> > >>> --- trunk/gui/win32/playlist.h    Thu Jul 21 03:21:36 2011 (r33887)
>> > >>> +++ trunk/gui/win32/playlist.h    Fri Jul 22 00:24:57 2011 (r33888)
>> > >>> @@ -56,6 +56,6 @@ struct playlist_t
>> > >>>
>> > >>> -BOOL adddirtoplaylist(playlist_t *playlist, const char* path, BOOL recursive);
>> > >>> +bool adddirtoplaylist(playlist_t *playlist, const char* path, bool recursive);
>> > >>
>> > >> Ingo, can you confirm this is OK or not?

Sorry, Diego, I overlooked this.

>> > >
>> > > I just confirmed this works fine on Cygwin, so I guess we can keep it.
>> >
>> > Well, bool has different semantic and also performance.
>> > Using int would be more similar in behaviour to BOOL and consistent
>> > with basically all other parts of MPlayer.
>>
>> Done.

> Thanks, I didn't mind much really though I guess a lot of people
> might still be unfamiliar with the special behaviour of the bool type,
> so it might be better to just avoid it...

Actually, I'd prefer a boolean type over int in case of a yes/no usage and
was thinking of introducing stdbool.h's true/false instead of the X11
True/False values in interface.c (which should be independent from any
specific UI). Performance shouldn't be an issue with the GUI, but I don't
know what you mean by "different semantic" or "special behaviour".

Ingo