[MPlayer-cvslog] r33955 - trunk/stream/cache2.c

[compn]

On Tue,  9 Aug 2011 19:36:49 +0200 (CEST), reimar wrote:
>Author: reimar
>Date: Tue Aug  9 19:36:49 2011
>New Revision: 33955
>
>Log:
>Mark two warnings that usually only indicate a performance issue as such.
>-      mp_msg(MSGT_CACHE, MSGL_WARN, "Cache not responding!\n");
>+      mp_msg(MSGT_CACHE, MSGL_WARN, "Cache not responding! [performance issue]


performance issue in mplayer? performance issue in network?
performance issue in users computer? kind of vague. 

i dont know a good replacement wording.

i dont understand what 'cache not responding!' means. do you think the
average user can figure it out ?

when playing a radio stream, after some time i'll get a bunch of
these (useless?) 'warnings'.

F:\mplayer-test>mplayer -cache 32 http://floyd.wcbn.org:8000/wcbn-hi.mp3
MPlayer Sherpya-SVN-r33574-4.2.5 (C) 2000-2011 MPlayer Team

i adjusted it to speed 1.46x to get the cache warning quicker.
but if you return to speed 1, the message persists even tho the stream
plays fine.

A:  23.4 (23.3) of -0.0 (unknown) 20.5% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  23.9 (23.9) of -0.0 (unknown) 21.0% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  24.5 (24.4) of -0.0 (unknown) 21.2% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  25.0 (25.0) of -0.0 (unknown) 21.4% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  25.5 (25.5) of -0.0 (unknown) 21.5% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  26.0 (26.0) of -0.0 (unknown) 21.8% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  26.6 (26.5) of -0.0 (unknown) 22.1% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  27.7 (27.6) of -0.0 (unknown) 22.4% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  28.2 (28.2) of -0.0 (unknown) 22.5% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  28.8 (28.7) of -0.0 (unknown) 22.7% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  29.3 (29.3) of -0.0 (unknown) 22.8% 0% 1.00x
Cache not filling, consider increasing -cache and/or -cache-min!
A:  29.9 (29.8) of -0.0 (unknown) 23.0% 0% 1.00x
  =====  PAUSE  =====

all of these messages fill up my console. were they added to find a bug ?

-	        mp_msg(MSGT_CACHE, MSGL_WARN, "Cache not filling, consider increasing -cache and/or -cache-min!\n");
+	        mp_msg(MSGT_CACHE, MSGL_WARN, "Cache not filling, consider increasing -cache and/or -cache-min. [performance issue]\n");

btw this message is 85 chars and thus will not look pretty on 80char terms ...

-compn