[MPlayer-cvslog] r34388 - in trunk/libass: ass_shaper.c ass_shaper.h

[Reimar Döffinger]

On Sun, Dec 04, 2011 at 01:06:31PM +0400, Yuriy Kaminskiy wrote:
> reimar wrote:
> > Author: reimar
> > Date: Sun Dec  4 00:08:03 2011
> > New Revision: 34388
> > 
> > Log:
> > Commit added forgotten in previous commit.
> > 
> > Added:
> >    trunk/libass/ass_shaper.c
> >    trunk/libass/ass_shaper.h
> > 
> [...]
> > Added: trunk/libass/ass_shaper.h
> > ==============================================================================
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ trunk/libass/ass_shaper.h	Sun Dec  4 00:08:03 2011	(r34388)
> > @@ -0,0 +1,43 @@
> > +/*
> ...
> > + */
> > +
> > +#ifndef LIBASS_SHAPER_H
> > +#define LIBASS_SHAPER_H
> > +
> > +#include "config.h"
> > +
> > +#include <fribidi/fribidi.h>
> 
> 1) now ass-internal unconditionally requires fribidi (missing configure check);
> not sure about version check - maybe it should be updated too; external libass
> configure.ac says it requires fribidi >= 0.19.0, mplayer's configure seems
> accept earlier versions;

Ugh, my fault for not checking more carefully.
fribidi seems to me like nothing that should be required, how many users
does it affect? < 1%?
Unfortunately the way it was designed it seems near impossible to
extract.

> 2) missing configure check for CONFIG_HARFBUZZ;

Actually that was intentional, doesn't seem all that useful and people
can still link against external libass.
Rather configure should be changed to prefer external unless it is
(seriously) outdated.