[MPlayer-cvslog] r32896 - trunk/gui/skin/font.c

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Feb 15 20:32:15 CET 2011

On Sun, Feb 13, 2011 at 01:42:37PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sun, 13 Feb 2011 12:41:38 +0100:
> > On Sat, Feb 12, 2011 at 11:15:18PM +0100, ib wrote:
> >> + if (item->Bitmap.Image && (item->height != th))
> > Useless pair of ()
> Yeah, I know but I like using these parentheses in the context of boolean or
> integer variables and such if one part of the expression is compound, for
> example:

Problem is it is contrary to all other code in MPlayer and FFmpeg
(with the exceptions of things gcc warns about like && vs. ||).
As long as it's the GUI code I won't tell you want to do, but I think
it would be better if you at least tried to get used to reading it without

More information about the MPlayer-cvslog mailing list