[MPlayer-cvslog] r32911 - in trunk: Makefile gui/skin/font.c

[Diego Biurrun]

On Wed, Feb 16, 2011 at 05:44:42PM +0100, ib wrote:
> 
> Log:
> Add additional include directory for gui.

This is not a good idea, please revert.  -I flags can cause the wrong
header to be picked if there are headers with similar names.  Since
some of the headers below gui/ have pretty generic names it is better
to just use proper relative paths in the #include statements.

> --- trunk/Makefile	Wed Feb 16 17:35:53 2011	(r32910)
> +++ trunk/Makefile	Wed Feb 16 17:44:42 2011	(r32911)
> @@ -856,7 +856,7 @@ mpcommon.o osdep/mplayer-rc.o: version.h
>  
> -gui/%: CFLAGS += -Wno-strict-prototypes
> +gui/%: CFLAGS += -Igui -Wno-strict-prototypes

This is an ugly hack that I still feel ashamed for, extending it
further is fueling my sense of guilt ;-)

Diego