[MPlayer-cvslog] r32925 - trunk/gui/skin/font.c

[Reimar Döffinger]

On Fri, Feb 18, 2011 at 11:38:39AM +0100, ib wrote:
> @@ -69,13 +69,11 @@ int fntRead( char * path,char * fname )
>   unsigned char   param[256];
>   int             id, n;
>  
> - id = fntAddNewFont( fname );
> -
> - if ( id < 0 ) return id;
> + if ( ( id = fntAddNewFont( fname ) ) < 0 ) return id;

Just on principle I have to say I considered the previous way
more readable.
Having assignments inside the "if" IMHO just makes things harder to
read without any real advantage.