[MPlayer-cvslog] r32931 - in trunk/gui/skin: skin.c skin.h

Diego Biurrun diego at biurrun.de
Sun Feb 27 10:00:03 CET 2011


On Sat, Feb 19, 2011 at 02:23:16PM +0100, ib wrote:
> 
> Log:
> Remove unused function.

Which unused function?

I note that almost all your log messages are one-liners.  Do you
happen to use the -m flag instead of writing them in an editor?
Please be more verbose.

A log message should describe what you did and why.  It should be
written for a person that does not know the context you have in your
head at the moment of writing it (future you for example) and not
require reading other log messages, commits, mails, whatever to
understand it.

Take your time to write log messages, I often spend several minutes
on finding a good concise description of a change and its reasons.

Diego


More information about the MPlayer-cvslog mailing list