[MPlayer-cvslog] r32980 - in trunk/gui: mplayer/gtk/sb.c mplayer/play.c skin/skin.c skin/skin.h

Diego Biurrun diego at biurrun.de
Mon Feb 28 13:54:00 CET 2011

On Sun, Feb 27, 2011 at 06:41:05PM +0100, ib wrote:
> Log:
> Get rid of needless listItems variable and pointer.
> The tmpList structure variable was only used to check whether a skin can be
> read without error. After the check tmpList was erased and the same skin read
> once again into another structure - the appropriate target structure. Now
> error checking is done with skin reading into the target structure.
> The separate skinAppMPlayer pointer was needless, because a skin will only be
> read into the one global listItems structure appMPlayer, so that its address
> can be used right away.
> Freeing the listItems was done twice before and is now performed at a single
> place, where the fonts are freed now as well - in skinRead() right before
> skin reading starts.
> As a result there is now only one listItems variable - the global appMPlayer;
> memory is saved, passing around global variables and pointless double actions
> are avoided.

This is one hell of a commit message, thanks :)


More information about the MPlayer-cvslog mailing list