[MPlayer-cvslog] r32984 - in trunk/gui: app.c app.h

Diego Biurrun diego at biurrun.de
Mon Feb 28 16:41:53 CET 2011

On Mon, Feb 28, 2011 at 03:20:17PM +0100, Ingo Brückl wrote:
> Diego Biurrun wrote on Mon, 28 Feb 2011 15:07:54 +0100:
> > On Mon, Feb 28, 2011 at 02:25:45PM +0100, ib wrote:
> >>
> >> Log:
> >> Cosmetic: Format to MPlayer coding style.
> > This is not the only thing that is happening here, witness...
> Yes, you're right. But the compiler output is the same.

That does not matter.  You claimed to do A, but did A, B and C.

> As the reformatting is cosmetic anyway, I though it wouldn't harm. Otherwise
> there would be multiple cosmetic-only commits. Is this preferred?

I don't mind multiple commits, I don't mind a single one for this much,
but I think Reimar prefers to see such things split.

What I do mind is commit messages that do not match the commits they
pretend to describe.  Commit message MUST NOT LIE. :)

Please adjust the log message so that it accurately describes your changes.


More information about the MPlayer-cvslog mailing list